settingsLogin | Registersettings

[openstack-dev] [Fuel] glusterfs plugin

0 votes

Hello,

I've been investigating bug [1] concentrating on the
fuel-plugin-external-glusterfs.

First of all: [2] there are no core reviewers for Gerrit for this repo
so even if there was a patch to fix [1] no one could merge it. I saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this format
does not support many features, such as plugins updates, find plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed [5].
Then I reverted the changes from the patch and the test still failed
[6]. But installing the plugin by hand shows that it's available there
so I don't know if it's broken plugin test or am I still missing something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]
https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
[6]
https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
asked Apr 1, 2015 in openstack-dev by Przemyslaw_Kaminski (1,820 points)   1 3

8 Responses

0 votes

Since there is no reply here I have taken steps to become core reviewer
of the (orphaned) repos [1], [2], [3], [4].

Should anyone want to take responsibility for them please write me.

I have also taken steps to get the fuel-qa script working and will make
sure tests pass with new manifests. I will also update manifests'
version so that there will be no deprecation warnings.

P.

[1]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-glusterfs,access
[2]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-group-based-policy,access
[3]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-nfs,access
[4]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-cinder-netapp,access

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
Hello,

I've been investigating bug [1] concentrating on the
fuel-plugin-external-glusterfs.

First of all: [2] there are no core reviewers for Gerrit for this repo
so even if there was a patch to fix [1] no one could merge it. I saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this format
does not support many features, such as plugins updates, find plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed [5].
Then I reverted the changes from the patch and the test still failed
[6]. But installing the plugin by hand shows that it's available there
so I don't know if it's broken plugin test or am I still missing something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]
https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
[6]
https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Przemyslaw_Kaminski (1,820 points)   1 3
0 votes

Hi Przemyslaw,
I would be glad to be core reviewer to fuel-plugin-glusterfs as long as
seems than I was only one person who push some commits to it.

On Thu, Apr 2, 2015 at 10:47 AM, Przemyslaw Kaminski <pkaminski@mirantis.com
wrote:

Since there is no reply here I have taken steps to become core reviewer
of the (orphaned) repos [1], [2], [3], [4].

Should anyone want to take responsibility for them please write me.

I have also taken steps to get the fuel-qa script working and will make
sure tests pass with new manifests. I will also update manifests'
version so that there will be no deprecation warnings.

P.

[1]

https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-glusterfs,access
[2]

https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-group-based-policy,access
[3]

https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-nfs,access
[4]

https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-cinder-netapp,access

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:

Hello,

I've been investigating bug [1] concentrating on the
fuel-plugin-external-glusterfs.

First of all: [2] there are no core reviewers for Gerrit for this repo
so even if there was a patch to fix [1] no one could merge it. I saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this format
does not support many features, such as plugins updates, find plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed [5].
Then I reverted the changes from the patch and the test still failed
[6]. But installing the plugin by hand shows that it's available there
so I don't know if it's broken plugin test or am I still missing
something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]

https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0

[6]

https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0
>


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Stanislaw_Bogatkin (2,160 points)   4
0 votes

Hello,

Done, added you.

I already created something that should fix the tests for glusterfs: [1]

Also the fuel-qa is not entirely correct for testing the glusterfs
plugin: here's the proposed fix [2].

Unfortunately the tests still fail with this message: [3]

I had an error about GLUSTERCLUSTERENDPOINT being undefined so I set
it like: GLUSTERCLUSTERENDPOINT=127.0.0.2:/mnt but I'm not sure if
it's correct (CI job has some custom-setup server with glusterfs for this).

Here are the logs [4]. Will you take over?

P.

[1] https://review.openstack.org/#/c/169683/
[2] https://review.openstack.org/170094
[3] http://sprunge.us/BYVY
[4]
https://www.dropbox.com/s/io6aeogidc49qxk/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_02__10_52_22.tar.xz?dl=0

On 04/02/2015 12:07 PM, Stanislaw Bogatkin wrote:
Hi Przemyslaw,
I would be glad to be core reviewer to fuel-plugin-glusterfs as long as
seems than I was only one person who push some commits to it.

On Thu, Apr 2, 2015 at 10:47 AM, Przemyslaw Kaminski
<pkaminski@mirantis.com pkaminski@mirantis.com> wrote:

Since there is no reply here I have taken steps to become core reviewer
of the (orphaned) repos [1], [2], [3], [4].

Should anyone want to take responsibility for them please write me.

I have also taken steps to get the fuel-qa script working and will make
sure tests pass with new manifests. I will also update manifests'
version so that there will be no deprecation warnings.

P.

[1]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-glusterfs,access
[2]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-group-based-policy,access
[3]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-external-nfs,access
[4]
https://review.openstack.org/#/admin/projects/stackforge/fuel-plugin-cinder-netapp,access

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
> Hello,
>
> I've been investigating bug [1] concentrating on the
> fuel-plugin-external-glusterfs.
>
> First of all: [2] there are no core reviewers for Gerrit for this repo
> so even if there was a patch to fix [1] no one could merge it. I saw
> also fuel-plugin-external-nfs -- same issue, haven't checked other
> repos. Why is this? Can we fix this quickly?
>
> Second, the plugin throws:
>
> DEPRECATION WARNING: The plugin has old 1.0 package format, this
format
> does not support many features, such as plugins updates, find
plugin in
> new format or migrate and rebuild this one.
>
> I don't think this is appropriate for a plugin that is listed in the
> official catalog [3].
>
> Third, I created a supposed fix for this bug [4] and wanted to test it
> with the fuel-qa scripts. Basically I built an .fp file with
> fuel-plugin-builder from that code, set the GLUSTER_PLUGIN_PATH
variable
> to point to that .fp file and then ran the
> group=deploy_ha_one_controller_glusterfs tests. The test failed [5].
> Then I reverted the changes from the patch and the test still failed
> [6]. But installing the plugin by hand shows that it's available there
> so I don't know if it's broken plugin test or am I still missing
something.
>
> It would be nice to get some QA help here.
>
> P.
>
> [1] https://bugs.launchpad.net/fuel/+bug/1415058
> [2] https://review.openstack.org/#/admin/groups/577,members
> [3] https://fuel-infra.org/plugins/catalog.html
> [4] https://review.openstack.org/#/c/169683/
> [5]
>
https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
> [6]
>
https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0
>

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Przemyslaw_Kaminski (1,820 points)   1 3
0 votes

Investigating the cinder-netapp plugin [1] (a 'certified' one) shows
fuel-plugin-build error:

(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ fpb --build
.

Unexpected error
Cannot find directories ./repositories/ubuntu for release
"{'repositorypath': 'repositories/ubuntu', 'version': '2014.2-6.0',
'os': 'ubuntu', 'mode': ['ha', 'multinode'], 'deployment
scriptspath':
'deployment
scripts/'}"
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ls
deploymentscripts environmentconfig.yaml LICENSE metadata.yaml
prebuildhook README.md tasks.yaml
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ag
'repositories'
metadata.yaml
18: repositorypath: repositories/ubuntu
23: repository
path: repositories/centos

Apparently some files are missing from the git repo or the manifest is
incorrect. Does anyone know something about this?

P.

[1] https://github.com/stackforge/fuel-plugin-cinder-netapp

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
Hello,

I've been investigating bug [1] concentrating on the
fuel-plugin-external-glusterfs.

First of all: [2] there are no core reviewers for Gerrit for this repo
so even if there was a patch to fix [1] no one could merge it. I saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this format
does not support many features, such as plugins updates, find plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed [5].
Then I reverted the changes from the patch and the test still failed
[6]. But installing the plugin by hand shows that it's available there
so I don't know if it's broken plugin test or am I still missing something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]
https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
[6]
https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Przemyslaw_Kaminski (1,820 points)   1 3
0 votes

Hi, Przemyslaw

1) There should be two repositories folders. Please check the correct
structure (marked with bold):
mkdir -p repositories/{ubuntu,centos}

root@55725ffa6e80:~/fuel-plugin-cinder-netapp# tree
.
|-- LICENSE
|-- README.md
|-- cindernetapp-1.0.0.fp
|-- deployment
scripts
| |-- puppet
| | -- plugin_cinder_netapp | |-- manifests
| | -- init.pp |-- site.pp
|-- environmentconfig.yaml
|-- metadata.yaml
|-- pre
build_hook

*|-- repositories| |-- centos| -- ubuntu*-- tasks.yaml

Then you can build the plugin.

2) Actually, this should not be the issue while creating plugins from
scratch using fpb tool itself [1]:

fpb --create test

root@55725ffa6e80:~# tree test
test
|-- LICENSE
|-- README.md
|-- deployment_scripts
| -- deploy.sh |-- environment_config.yaml |-- metadata.yaml |-- pre_build_hook |-- repositories | |-- centos |-- ubuntu
`-- tasks.yaml

[1]. https://pypi.python.org/pypi/fuel-plugin-builder/1.0.2

2015-04-02 16:30 GMT+03:00 Przemyslaw Kaminski pkaminski@mirantis.com:

Investigating the cinder-netapp plugin [1] (a 'certified' one) shows
fuel-plugin-build error:

(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ fpb --build
.

Unexpected error
Cannot find directories ./repositories/ubuntu for release
"{'repositorypath': 'repositories/ubuntu', 'version': '2014.2-6.0',
'os': 'ubuntu', 'mode': ['ha', 'multinode'], 'deployment
scriptspath':
'deployment
scripts/'}"
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ls
deploymentscripts environmentconfig.yaml LICENSE metadata.yaml
prebuildhook README.md tasks.yaml
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ag
'repositories'
metadata.yaml
18: repositorypath: repositories/ubuntu
23: repository
path: repositories/centos

Apparently some files are missing from the git repo or the manifest is
incorrect. Does anyone know something about this?

P.

[1] https://github.com/stackforge/fuel-plugin-cinder-netapp

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:

Hello,

I've been investigating bug [1] concentrating on the
fuel-plugin-external-glusterfs.

First of all: [2] there are no core reviewers for Gerrit for this repo
so even if there was a patch to fix [1] no one could merge it. I saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this format
does not support many features, such as plugins updates, find plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed [5].
Then I reverted the changes from the patch and the test still failed
[6]. But installing the plugin by hand shows that it's available there
so I don't know if it's broken plugin test or am I still missing
something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]

https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0

[6]

https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0
>


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Sergey
DevOps Engineer
IRC: SergK
Skype: Sergey_kul


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Sergey_Kulanov (460 points)   1 2
0 votes

Well then either we need to fix fuel-plugin-builder to accept such
situations.

Actually it is an issue with fpb since git does not accepty empty
directories [1] so pulling fresh from such repo will result in
'repositories' dir missing even when the developer had it.

I hope no files were accidentaly forgotten during commit there?

P.

[1]
http://stackoverflow.com/questions/115983/how-can-i-add-an-empty-directory-to-a-git-repository

On 04/02/2015 03:46 PM, Sergey Kulanov wrote:
Hi, Przemyslaw

1) There should be two repositories folders. Please check the correct
structure (marked with bold):
mkdir -p repositories/{ubuntu,centos}

root@55725ffa6e80:~/fuel-plugin-cinder-netapp# tree
.
|-- LICENSE
|-- README.md
|-- cindernetapp-1.0.0.fp
|-- deployment
scripts
| |-- puppet
| | -- plugin_cinder_netapp | |-- manifests
| | -- init.pp |-- site.pp
|-- environmentconfig.yaml
|-- metadata.yaml
|-- pre
build_hook
*|-- repositories
| |-- centos
| -- ubuntu *-- tasks.yaml

Then you can build the plugin.

2) Actually, this should not be the issue while creating plugins from
scratch using fpb tool itself [1]:

fpb --create test

root@55725ffa6e80:~# tree test
test
|-- LICENSE
|-- README.md
|-- deployment_scripts
| -- deploy.sh |-- environment_config.yaml |-- metadata.yaml |-- pre_build_hook |-- repositories | |-- centos |-- ubuntu
`-- tasks.yaml

[1]. https://pypi.python.org/pypi/fuel-plugin-builder/1.0.2

2015-04-02 16:30 GMT+03:00 Przemyslaw Kaminski <pkaminski@mirantis.com
pkaminski@mirantis.com>:

Investigating the cinder-netapp plugin [1] (a 'certified' one) shows
fuel-plugin-build error:

(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ fpb --build
.


Unexpected error
Cannot find directories ./repositories/ubuntu for release
"{'repository_path': 'repositories/ubuntu', 'version': '2014.2-6.0',
'os': 'ubuntu', 'mode': ['ha', 'multinode'], 'deployment_scripts_path':
'deployment_scripts/'}"
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ls
deployment_scripts  environment_config.yaml  LICENSE  metadata.yaml
pre_build_hook  README.md  tasks.yaml
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ag
'repositories'
metadata.yaml
18:    repository_path: repositories/ubuntu
23:    repository_path: repositories/centos

Apparently some files are missing from the git repo or the manifest is
incorrect. Does anyone know something about this?

P.

[1] https://github.com/stackforge/fuel-plugin-cinder-netapp

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
> Hello,
>
> I've been investigating bug [1] concentrating on the
> fuel-plugin-external-glusterfs.
>
> First of all: [2] there are no core reviewers for Gerrit for this repo
> so even if there was a patch to fix [1] no one could merge it. I saw
> also fuel-plugin-external-nfs -- same issue, haven't checked other
> repos. Why is this? Can we fix this quickly?
>
> Second, the plugin throws:
>
> DEPRECATION WARNING: The plugin has old 1.0 package format, this
format
> does not support many features, such as plugins updates, find
plugin in
> new format or migrate and rebuild this one.
>
> I don't think this is appropriate for a plugin that is listed in the
> official catalog [3].
>
> Third, I created a supposed fix for this bug [4] and wanted to test it
> with the fuel-qa scripts. Basically I built an .fp file with
> fuel-plugin-builder from that code, set the GLUSTER_PLUGIN_PATH
variable
> to point to that .fp file and then ran the
> group=deploy_ha_one_controller_glusterfs tests. The test failed [5].
> Then I reverted the changes from the patch and the test still failed
> [6]. But installing the plugin by hand shows that it's available there
> so I don't know if it's broken plugin test or am I still missing
something.
>
> It would be nice to get some QA help here.
>
> P.
>
> [1] https://bugs.launchpad.net/fuel/+bug/1415058
> [2] https://review.openstack.org/#/admin/groups/577,members
> [3] https://fuel-infra.org/plugins/catalog.html
> [4] https://review.openstack.org/#/c/169683/
> [5]
>
https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
> [6]
>
https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0
>

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Sergey
DevOps Engineer
IRC: SergK
Skype: Sergey_kul


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Przemyslaw_Kaminski (1,820 points)   1 3
0 votes

I've just print tree with hidden files, so actually it's ok with fpb:

root@55725ffa6e80:~# tree -a test/
test/
|-- .gitignore
|-- LICENSE
|-- README.md
|-- deploymentscripts
| `-- deploy.sh
|-- environment
config.yaml
|-- metadata.yaml
|-- prebuildhook

*|-- repositories| |-- centos| | -- .gitkeep|-- ubuntu|
-- .gitkeep*-- tasks.yaml

2015-04-02 17:01 GMT+03:00 Przemyslaw Kaminski pkaminski@mirantis.com:

Well then either we need to fix fuel-plugin-builder to accept such
situations.

Actually it is an issue with fpb since git does not accepty empty
directories [1] so pulling fresh from such repo will result in
'repositories' dir missing even when the developer had it.

I hope no files were accidentaly forgotten during commit there?

P.

[1]

http://stackoverflow.com/questions/115983/how-can-i-add-an-empty-directory-to-a-git-repository

On 04/02/2015 03:46 PM, Sergey Kulanov wrote:

Hi, Przemyslaw

1) There should be two repositories folders. Please check the correct
structure (marked with bold):
mkdir -p repositories/{ubuntu,centos}

root@55725ffa6e80:~/fuel-plugin-cinder-netapp# tree
.
|-- LICENSE
|-- README.md
|-- cindernetapp-1.0.0.fp
|-- deployment
scripts
| |-- puppet
| | -- plugin_cinder_netapp | |-- manifests
| | -- init.pp |-- site.pp
|-- environmentconfig.yaml
|-- metadata.yaml
|-- pre
build_hook
*|-- repositories
| |-- centos
| -- ubuntu *-- tasks.yaml

Then you can build the plugin.

2) Actually, this should not be the issue while creating plugins from
scratch using fpb tool itself [1]:

fpb --create test

root@55725ffa6e80:~# tree test
test
|-- LICENSE
|-- README.md
|-- deployment_scripts
| -- deploy.sh |-- environment_config.yaml |-- metadata.yaml |-- pre_build_hook |-- repositories | |-- centos |-- ubuntu
`-- tasks.yaml

[1]. https://pypi.python.org/pypi/fuel-plugin-builder/1.0.2

2015-04-02 16:30 GMT+03:00 Przemyslaw Kaminski <pkaminski@mirantis.com
pkaminski@mirantis.com>:

Investigating the cinder-netapp plugin [1] (a 'certified' one) shows
fuel-plugin-build error:

(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ fpb

--build
.

Unexpected error
Cannot find directories ./repositories/ubuntu for release
"{'repository_path': 'repositories/ubuntu', 'version': '2014.2-6.0',
'os': 'ubuntu', 'mode': ['ha', 'multinode'],

'deploymentscriptspath':
'deploymentscripts/'}"
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ls
deployment
scripts environmentconfig.yaml LICENSE metadata.yaml
pre
buildhook README.md tasks.yaml
(fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ag
'repositories'
metadata.yaml
18: repository
path: repositories/ubuntu
23: repository_path: repositories/centos

Apparently some files are missing from the git repo or the manifest

is
incorrect. Does anyone know something about this?

P.

[1] https://github.com/stackforge/fuel-plugin-cinder-netapp

On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
> Hello,
>
> I've been investigating bug [1] concentrating on the
> fuel-plugin-external-glusterfs.
>
> First of all: [2] there are no core reviewers for Gerrit for this

repo

so even if there was a patch to fix [1] no one could merge it. I
saw
also fuel-plugin-external-nfs -- same issue, haven't checked other
repos. Why is this? Can we fix this quickly?

Second, the plugin throws:

DEPRECATION WARNING: The plugin has old 1.0 package format, this
format
does not support many features, such as plugins updates, find
plugin in
new format or migrate and rebuild this one.

I don't think this is appropriate for a plugin that is listed in
the
official catalog [3].

Third, I created a supposed fix for this bug [4] and wanted to
test it
with the fuel-qa scripts. Basically I built an .fp file with
fuel-plugin-builder from that code, set the GLUSTERPLUGINPATH
variable
to point to that .fp file and then ran the
group=deployhaonecontrollerglusterfs tests. The test failed
[5].
Then I reverted the changes from the patch and the test still
failed
[6]. But installing the plugin by hand shows that it's available
there
so I don't know if it's broken plugin test or am I still missing
something.

It would be nice to get some QA help here.

P.

[1] https://bugs.launchpad.net/fuel/+bug/1415058
[2] https://review.openstack.org/#/admin/groups/577,members
[3] https://fuel-infra.org/plugins/catalog.html
[4] https://review.openstack.org/#/c/169683/
[5]

https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0

> [6]
>

https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0

>

OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
<

http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Sergey
DevOps Engineer
IRC: SergK
Skype: Sergey_kul


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Sergey
DevOps Engineer
IRC: SergK
Skype: Sergey_kul


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Sergey_Kulanov (460 points)   1 2
0 votes

Well this directory structure is not true for [1] and the suggestion
about fpb was for such repos.

P.

https://github.com/stackforge/fuel-plugin-cinder-netapp

On 04/02/2015 04:08 PM, Sergey Kulanov wrote:
I've just print tree with hidden files, so actually it's ok with fpb:

root@55725ffa6e80:~# tree -a test/
test/
|-- .gitignore
|-- LICENSE
|-- README.md
|-- deployment_scripts
| -- deploy.sh |-- environment_config.yaml |-- metadata.yaml |-- pre_build_hook *|-- repositories | |-- centos | |-- .gitkeep
| -- ubuntu |-- .gitkeep
*`-- tasks.yaml

2015-04-02 17:01 GMT+03:00 Przemyslaw Kaminski <pkaminski@mirantis.com
pkaminski@mirantis.com>:

Well then either we need to fix fuel-plugin-builder to accept such
situations.

Actually it is an issue with fpb since git does not accepty empty
directories [1] so pulling fresh from such repo will result in
'repositories' dir missing even when the developer had it.

I hope no files were accidentaly forgotten during commit there?

P.

[1]
http://stackoverflow.com/questions/115983/how-can-i-add-an-empty-directory-to-a-git-repository

On 04/02/2015 03:46 PM, Sergey Kulanov wrote:
> Hi, Przemyslaw
>
> 1) There should be two repositories folders. Please check the correct
> structure (marked with bold):
> mkdir -p repositories/{ubuntu,centos}
>
>
> root@55725ffa6e80:~/fuel-plugin-cinder-netapp# tree
> .
> |-- LICENSE
> |-- README.md
> |-- cinder_netapp-1.0.0.fp
> |-- deployment_scripts
> |   |-- puppet
> |   |   `-- plugin_cinder_netapp
> |   |       `-- manifests
> |   |           `-- init.pp
> |   `-- site.pp
> |-- environment_config.yaml
> |-- metadata.yaml
> |-- pre_build_hook
> *|-- repositories
> |   |-- centos
> |   `-- ubuntu
> *`-- tasks.yaml
>
> Then you can build the plugin.
>
> 2) Actually, this should not be the issue while creating plugins from
> scratch using fpb tool itself [1]:
>
> fpb --create test
>
> root@55725ffa6e80:~# tree test
> test
> |-- LICENSE
> |-- README.md
> |-- deployment_scripts
> |   `-- deploy.sh
> |-- environment_config.yaml
> |-- metadata.yaml
> |-- pre_build_hook
> |-- repositories
> |   |-- centos
> |   `-- ubuntu
> `-- tasks.yaml
>
>
>
> [1]. https://pypi.python.org/pypi/fuel-plugin-builder/1.0.2
>
>
> 2015-04-02 16:30 GMT+03:00 Przemyslaw Kaminski <pkaminski@mirantis.com <mailto:pkaminski@mirantis.com>
> <mailto:pkaminski@mirantis.com <mailto:pkaminski@mirantis.com>>>:
>
>     Investigating the cinder-netapp plugin [1] (a 'certified' one)
shows
>     fuel-plugin-build error:
>
>     (fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$
fpb --build
>     .
>
>
>     Unexpected error
>     Cannot find directories ./repositories/ubuntu for release
>     "{'repository_path': 'repositories/ubuntu', 'version':
'2014.2-6.0',
>     'os': 'ubuntu', 'mode': ['ha', 'multinode'],
'deployment_scripts_path':
>     'deployment_scripts/'}"
>     (fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ls
>     deployment_scripts  environment_config.yaml  LICENSE 
metadata.yaml
>     pre_build_hook  README.md  tasks.yaml
>     (fuel)vagrant@ubuntu-14:/sources/fuel-plugin-cinder-netapp$ ag
>     'repositories'
>     metadata.yaml
>     18:    repository_path: repositories/ubuntu
>     23:    repository_path: repositories/centos
>
>     Apparently some files are missing from the git repo or the
manifest is
>     incorrect. Does anyone know something about this?
>
>     P.
>
>     [1] https://github.com/stackforge/fuel-plugin-cinder-netapp
>
>     On 04/01/2015 03:48 PM, Przemyslaw Kaminski wrote:
>     > Hello,
>     >
>     > I've been investigating bug [1] concentrating on the
>     > fuel-plugin-external-glusterfs.
>     >
>     > First of all: [2] there are no core reviewers for Gerrit for
this repo
>     > so even if there was a patch to fix [1] no one could merge
it. I saw
>     > also fuel-plugin-external-nfs -- same issue, haven't checked
other
>     > repos. Why is this? Can we fix this quickly?
>     >
>     > Second, the plugin throws:
>     >
>     > DEPRECATION WARNING: The plugin has old 1.0 package format, this
>     format
>     > does not support many features, such as plugins updates, find
>     plugin in
>     > new format or migrate and rebuild this one.
>     >
>     > I don't think this is appropriate for a plugin that is
listed in the
>     > official catalog [3].
>     >
>     > Third, I created a supposed fix for this bug [4] and wanted
to test it
>     > with the fuel-qa scripts. Basically I built an .fp file with
>     > fuel-plugin-builder from that code, set the GLUSTER_PLUGIN_PATH
>     variable
>     > to point to that .fp file and then ran the
>     > group=deploy_ha_one_controller_glusterfs tests. The test
failed [5].
>     > Then I reverted the changes from the patch and the test
still failed
>     > [6]. But installing the plugin by hand shows that it's
available there
>     > so I don't know if it's broken plugin test or am I still missing
>     something.
>     >
>     > It would be nice to get some QA help here.
>     >
>     > P.
>     >
>     > [1] https://bugs.launchpad.net/fuel/+bug/1415058
>     > [2] https://review.openstack.org/#/admin/groups/577,members
>     > [3] https://fuel-infra.org/plugins/catalog.html
>     > [4] https://review.openstack.org/#/c/169683/
>     > [5]
>     >
>   
 https://www.dropbox.com/s/1mhz8gtm2j391mr/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__11_39_11.tar.xz?dl=0
>     > [6]
>     >
>   
 https://www.dropbox.com/s/ehjox554xl23xgv/fail_error_deploy_ha_one_controller_glusterfs_simple-2015_04_01__13_16_11.tar.xz?dl=0
>     >
>
>   
 __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request@lists.openstack.org?subject:unsubscribe

>   
 
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> Sergey
> DevOps Engineer
> IRC: SergK
> Skype: Sergey_kul
>
>
>
__________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe

> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Sergey
DevOps Engineer
IRC: SergK
Skype: Sergey_kul


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Apr 2, 2015 by Przemyslaw_Kaminski (1,820 points)   1 3
...