settingsLogin | Registersettings

[openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

0 votes

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can we
enable auto-abandon back again, if patch is hanging out for a month or more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
asked Jul 7, 2015 in openstack-dev by Mike_Scherbakov (9,460 points)   1 4 6

15 Responses

0 votes

3 Months should be a good period. Sometimes, people have one month vacation
thus it might be a problem in such cases.

--
Best regards,
Sergii Golovatiuk,
Skype #golserge
IRC #holser

On Tue, Jul 7, 2015 at 3:34 PM, Mike Scherbakov mscherbakov@mirantis.com
wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can we
enable auto-abandon back again, if patch is hanging out for a month or more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Sergii_Golovatiuk (6,080 points)   1 2 3
0 votes

+1 for enabling auto-abandon

Sergii, I think the period should be smaller, 2 weeks - 1 month,
if patch is important, the author will unabandon it.

Thanks,

On Wed, Jul 8, 2015 at 3:50 AM, Sergii Golovatiuk sgolovatiuk@mirantis.com
wrote:

3 Months should be a good period. Sometimes, people have one month
vacation thus it might be a problem in such cases.

--
Best regards,
Sergii Golovatiuk,
Skype #golserge
IRC #holser

On Tue, Jul 7, 2015 at 3:34 PM, Mike Scherbakov mscherbakov@mirantis.com
wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can
we enable auto-abandon back again, if patch is hanging out for a month or
more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Evgeniy_L (8,580 points)   1 2 4
0 votes

+1

On Wed, Jul 8, 2015 at 10:44 AM, Evgeniy L eli@mirantis.com wrote:

+1 for enabling auto-abandon

Sergii, I think the period should be smaller, 2 weeks - 1 month,
if patch is important, the author will unabandon it.

Thanks,

On Wed, Jul 8, 2015 at 3:50 AM, Sergii Golovatiuk <
sgolovatiuk@mirantis.com> wrote:

3 Months should be a good period. Sometimes, people have one month
vacation thus it might be a problem in such cases.

--
Best regards,
Sergii Golovatiuk,
Skype #golserge
IRC #holser

On Tue, Jul 7, 2015 at 3:34 PM, Mike Scherbakov <mscherbakov@mirantis.com

wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can
we enable auto-abandon back again, if patch is hanging out for a month or
more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Yours Faithfully,
Vladimir Kuklin,
Fuel Library Tech Lead,
Mirantis, Inc.
+7 (495) 640-49-04
+7 (926) 702-39-68
Skype kuklinvv
35bk3, Vorontsovskaya Str.
Moscow, Russia,
www.mirantis.com
www.mirantis.ru
vkuklin@mirantis.com


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Vladimir_Kuklin (7,320 points)   1 3 4
0 votes

+1 for one month.

On Wed, Jul 8, 2015 at 12:54 PM, Vladimir Kuklin vkuklin@mirantis.com
wrote:

+1

On Wed, Jul 8, 2015 at 10:44 AM, Evgeniy L eli@mirantis.com wrote:

+1 for enabling auto-abandon

Sergii, I think the period should be smaller, 2 weeks - 1 month,
if patch is important, the author will unabandon it.

Thanks,

On Wed, Jul 8, 2015 at 3:50 AM, Sergii Golovatiuk <
sgolovatiuk@mirantis.com> wrote:

3 Months should be a good period. Sometimes, people have one month
vacation thus it might be a problem in such cases.

--
Best regards,
Sergii Golovatiuk,
Skype #golserge
IRC #holser

On Tue, Jul 7, 2015 at 3:34 PM, Mike Scherbakov <
mscherbakov@mirantis.com> wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can
we enable auto-abandon back again, if patch is hanging out for a month or
more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Yours Faithfully,
Vladimir Kuklin,
Fuel Library Tech Lead,
Mirantis, Inc.
+7 (495) 640-49-04
+7 (926) 702-39-68
Skype kuklinvv
35bk3, Vorontsovskaya Str.
Moscow, Russia,
www.mirantis.com
www.mirantis.ru
vkuklin@mirantis.com


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Andrey Danin
adanin@mirantis.com
skype: gcon.monolake


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Andrey_Danin (1,620 points)   4
0 votes

Given this is inactivity timeout, 2 weeks seem more than enough. Mind
that the discussion without any patch sets incoming counts against this
limit as well.

And basically, if you go on a lenghty vacation, you better finish with all
your CRs before that. During that time it's likely that changes will
require manual rebase anyways, so no point to keep them in listings and
search results.

So I'm for 2 weeks auto-abandon period.

--
Best regards,
Oleg Gelbukh

On Tue, Jul 7, 2015 at 11:34 PM, Mike Scherbakov mscherbakov@mirantis.com
wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can we
enable auto-abandon back again, if patch is hanging out for a month or more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Oleg_Gelbukh (3,480 points)   1 2
0 votes

Hi,

My 2 cents on it.

Let's abandon patch:

  • if there's at least one -1, and there were no activity for 2 weeks
  • if it has positive feedback, bat there were no activity for 4 weeks

Thanks,
Igor

On Wed, Jul 8, 2015 at 2:33 PM, Oleg Gelbukh ogelbukh@mirantis.com wrote:
Given this is inactivity timeout, 2 weeks seem more than enough. Mind that
the discussion without any patch sets incoming counts against this limit as
well.

And basically, if you go on a lenghty vacation, you better finish with all
your CRs before that. During that time it's likely that changes will require
manual rebase anyways, so no point to keep them in listings and search
results.

So I'm for 2 weeks auto-abandon period.

--
Best regards,
Oleg Gelbukh

On Tue, Jul 7, 2015 at 11:34 PM, Mike Scherbakov mscherbakov@mirantis.com
wrote:

Hi,
we have too many patches which hang for over a month without attention.
Almost all are those which should be abandoned due to changes happened in
master, and need complete rework. Or, those were just proposals to make
something, which didn't fly. Unfortunately there are those which were good
ideas, but didn't attract enough attention from cores and didn't land into
master as a result.

Anyway, I think we need to keep our review queues in better health. Can we
enable auto-abandon back again, if patch is hanging out for a month or more?
--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Igor_Kalnitsky (8,940 points)   1 2 4
0 votes

Let's keep it at >4 weeks without comment, and Jenkins failed - similar
to the script that Kyle Mestery uses for Neutron. In fact, we could
actually just use his script ;)

https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh
--
Sean M. Collins


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 8, 2015 by Sean_M._Collins (11,480 points)   3 7 11
0 votes

+1 for just reusing existing script, and adjust it on the way. No need to
immediately switch from infinite time to a couple of weeks, we can always
adjust it later. But 1-2 month should be a good start already.

Our current stats [1] look just terrible. Before we enable an auto-abandon,
we need to go every single patch first, and review it / provide comment to
authors. The idea is not to abandon some good patches, and not to offend
contributors...

Let's think how we can approach it. Should we have core reviewers to check
their corresponding components?

[1] http://stackalytics.com/report/reviews/fuel-group/open

On Wed, Jul 8, 2015 at 1:13 PM Sean M. Collins sean@coreitpro.com wrote:

Let's keep it at >4 weeks without comment, and Jenkins failed - similar
to the script that Kyle Mestery uses for Neutron. In fact, we could
actually just use his script ;)

https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh
--
Sean M. Collins


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 9, 2015 by Mike_Scherbakov (9,460 points)   1 4 6
0 votes

That's a very good plan ("Initial feedback/triage") Mike.

thanks,
dims

On Thu, Jul 9, 2015 at 3:23 PM, Mike Scherbakov
mscherbakov@mirantis.com wrote:
+1 for just reusing existing script, and adjust it on the way. No need to
immediately switch from infinite time to a couple of weeks, we can always
adjust it later. But 1-2 month should be a good start already.

Our current stats [1] look just terrible. Before we enable an auto-abandon,
we need to go every single patch first, and review it / provide comment to
authors. The idea is not to abandon some good patches, and not to offend
contributors...

Let's think how we can approach it. Should we have core reviewers to check
their corresponding components?

[1] http://stackalytics.com/report/reviews/fuel-group/open

On Wed, Jul 8, 2015 at 1:13 PM Sean M. Collins sean@coreitpro.com wrote:

Let's keep it at >4 weeks without comment, and Jenkins failed - similar
to the script that Kyle Mestery uses for Neutron. In fact, we could
actually just use his script ;)

https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh
--
Sean M. Collins


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Davanum Srinivas :: https://twitter.com/dims


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 9, 2015 by Davanum_Srinivas (35,920 points)   2 4 9
0 votes

2 weeks seems too small for me. We easy can be in situation when fix for
medium bug is done, but SCF starts. And gap between SCF and release easily
can be more than a month. So, 2 months seems okay for me if speaking about
forcibly applying auto-abandon by major vote. And I'm personally against
such innovation at all.

On Thu, Jul 9, 2015 at 5:37 PM, Davanum Srinivas davanum@gmail.com wrote:

That's a very good plan ("Initial feedback/triage") Mike.

thanks,
dims

On Thu, Jul 9, 2015 at 3:23 PM, Mike Scherbakov
mscherbakov@mirantis.com wrote:

+1 for just reusing existing script, and adjust it on the way. No need to
immediately switch from infinite time to a couple of weeks, we can always
adjust it later. But 1-2 month should be a good start already.

Our current stats [1] look just terrible. Before we enable an
auto-abandon,
we need to go every single patch first, and review it / provide comment
to
authors. The idea is not to abandon some good patches, and not to offend
contributors...

Let's think how we can approach it. Should we have core reviewers to
check
their corresponding components?

[1] http://stackalytics.com/report/reviews/fuel-group/open

On Wed, Jul 8, 2015 at 1:13 PM Sean M. Collins sean@coreitpro.com
wrote:

Let's keep it at >4 weeks without comment, and Jenkins failed - similar
to the script that Kyle Mestery uses for Neutron. In fact, we could
actually just use his script ;)

https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh

--
Sean M. Collins


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Mike Scherbakov

mihgen


OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

--
Davanum Srinivas :: https://twitter.com/dims


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded Jul 10, 2015 by Stanislaw_Bogatkin (2,160 points)   4
...