settingsLogin | Registersettings

[openstack-dev] suds-jurko, new in our global-requirements.txt: what is the point?!?

0 votes

Hi,

I tried to package suds-jurko. I was first happy to see that there was
some progress to make things work with Python 3. Unfortunately, the
reality is that suds-jurko has many issues with Python 3. For example,
it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix some of these
issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which is half-baked,
and which will conflict with the suds package?

Cheers,

Thomas Goirand (zigo)

asked Nov 26, 2014 in openstack-dev by Thomas_Goirand (18,640 points)   3 11 16
retagged Jan 28, 2015 by admin

6 Responses

0 votes

On Nov 26, 2014, at 10:34 AM, Thomas Goirand wrote:

Hi,

I tried to package suds-jurko. I was first happy to see that there was
some progress to make things work with Python 3. Unfortunately, the
reality is that suds-jurko has many issues with Python 3. For example,
it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix some of these
issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which is half-baked,
and which will conflict with the suds package?

It looks like it uses 2to3 to become Python 3 compatible.


Donald Stufft
PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
responded Nov 26, 2014 by Donald_Stufft (2,440 points)   2 2
0 votes

On 11/27/2014 12:31 AM, Donald Stufft wrote:

On Nov 26, 2014, at 10:34 AM, Thomas Goirand wrote:

Hi,

I tried to package suds-jurko. I was first happy to see that there was
some progress to make things work with Python 3. Unfortunately, the
reality is that suds-jurko has many issues with Python 3. For example,
it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix some of these
issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which is half-baked,
and which will conflict with the suds package?

It looks like it uses 2to3 to become Python 3 compatible.

Outch! That's horrible.

I think it'd be best if someone spent some time on writing real code
rather than using such a hack as 2to3. Thoughts anyone?

Cheers,

Thomas Goirand (zigo)

responded Nov 27, 2014 by Thomas_Goirand (18,640 points)   3 11 16
0 votes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 27/11/14 12:09, Thomas Goirand wrote:
On 11/27/2014 12:31 AM, Donald Stufft wrote:

On Nov 26, 2014, at 10:34 AM, Thomas Goirand
wrote:

Hi,

I tried to package suds-jurko. I was first happy to see that
there was some progress to make things work with Python 3.
Unfortunately, the reality is that suds-jurko has many issues
with Python 3. For example, it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix some
of these issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which is
half-baked, and which will conflict with the suds package?

It looks like it uses 2to3 to become Python 3 compatible.

Outch! That's horrible.

I think it'd be best if someone spent some time on writing real
code rather than using such a hack as 2to3. Thoughts anyone?

That sounds very subjective. If upstream is able to support multiple
python versions from the same codebase, then I see no reason for them
to split the code into multiple branches and introduce additional
burden syncing fixes between those.

/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iQEcBAEBCgAGBQJUd0wMAAoJEC5aWaUY1u57gVMIAI70aQjReaa32WVJExL18c4t
QfJ3U+4yGxURIwqu/VKfpujN+KNQ7JWR+zqSUpv1gGxRTQcwFYLLKeW9XRxBnETw
0YxLvCrju3MInFDCFZrJzm3mTMlnQSosQSoK08Phn++cyRs1R/isaWPU7UHMbiSM
jIqRQkLYYPoSnhiTm1LkOoWg3oP82g3vxOPQmAlTAlx38lJ81ioBq7z9rRQzW+CX
DcZy+64t+iePY9w0P4mvXdl/saDAlh7Hl/nu7RKcC5ycoa2un07N6SAazycMPvln
naQvaXFfjPjGP5ToLNWIDwhRWmMkUa581ng37+6LewvbFNUDttKCHobp8cvVqy8=
=d0S7
-----END PGP SIGNATURE-----

responded Nov 27, 2014 by Ihar_Hrachyshka (35,300 points)   3 10 16
0 votes

On 11/28/2014 12:06 AM, Ihar Hrachyshka wrote:
On 27/11/14 12:09, Thomas Goirand wrote:

On 11/27/2014 12:31 AM, Donald Stufft wrote:

On Nov 26, 2014, at 10:34 AM, Thomas Goirand
wrote:

Hi,

I tried to package suds-jurko. I was first happy to see that
there was some progress to make things work with Python 3.
Unfortunately, the reality is that suds-jurko has many issues
with Python 3. For example, it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix some
of these issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which is
half-baked, and which will conflict with the suds package?

It looks like it uses 2to3 to become Python 3 compatible.

Outch! That's horrible.

I think it'd be best if someone spent some time on writing real
code rather than using such a hack as 2to3. Thoughts anyone?

That sounds very subjective. If upstream is able to support multiple
python versions from the same codebase, then I see no reason for them
to split the code into multiple branches and introduce additional
burden syncing fixes between those.

/Ihar

Objectively, using 2to3 sux, and it's much better to fix the code,
rather than using such a band-aid. It is possible to support multiple
version of Python with a single code base. So many projects are able to
do it, I don't see why suds would be any different.

Cheers,

Thomas

responded Nov 27, 2014 by Thomas_Goirand (18,640 points)   3 11 16
0 votes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 27/11/14 19:10, Thomas Goirand wrote:
On 11/28/2014 12:06 AM, Ihar Hrachyshka wrote:

On 27/11/14 12:09, Thomas Goirand wrote:

On 11/27/2014 12:31 AM, Donald Stufft wrote:

On Nov 26, 2014, at 10:34 AM, Thomas Goirand
wrote:

Hi,

I tried to package suds-jurko. I was first happy to see
that there was some progress to make things work with
Python 3. Unfortunately, the reality is that suds-jurko has
many issues with Python 3. For example, it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix
some of these issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which
is half-baked, and which will conflict with the suds
package?

It looks like it uses 2to3 to become Python 3 compatible.

Outch! That's horrible.

I think it'd be best if someone spent some time on writing
real code rather than using such a hack as 2to3. Thoughts
anyone?

That sounds very subjective. If upstream is able to support
multiple python versions from the same codebase, then I see no
reason for them to split the code into multiple branches and
introduce additional burden syncing fixes between those.

/Ihar

Objectively, using 2to3 sux, and it's much better to fix the code,
rather than using such a band-aid. It is possible to support
multiple version of Python with a single code base. So many
projects are able to do it, I don't see why suds would be any
different.

Their support matrix starts from Python 2.4. Maybe that's a reason for
band-aid and not using runtime cross-version wrappers.
/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iQEcBAEBCgAGBQJUeF4XAAoJEC5aWaUY1u57Ty0IALsSr5MRNvpuq9g0/GTFGynh
qXraVZ/km+whgFtrheyM4+tVuwew2aY7y1Sb/ACuvjqBmtbnWPqEFgD/LIhmSe+R
uraelATiECOWnHLYYfIdQp8r3NkxlI1C2bwc6UkELYVgg/4mjqZa6ZtwSIkJB/2H
BrZ7Z45no0zIkAIDMPtc7GEG3aWPFLEhT7sG0JEu59z/F964wP6bXZrm3iqUxE1u
ft4mQBe3DCMhVjbhCLBXid843lvPLboOIcgRswKQc1GOjFCU3DEfKdTsxDr+koS2
UPc6UkOWR9pN/X5riijrSIg2QPTtJrIjRvdgzc/TJfq3K9h1Z+FxIsmKUFHM4Ls=
=Xl13
-----END PGP SIGNATURE-----

responded Nov 28, 2014 by Ihar_Hrachyshka (35,300 points)   3 10 16
0 votes

On 11/28/2014 07:35 PM, Ihar Hrachyshka wrote:
On 27/11/14 19:10, Thomas Goirand wrote:

On 11/28/2014 12:06 AM, Ihar Hrachyshka wrote:

On 27/11/14 12:09, Thomas Goirand wrote:

On 11/27/2014 12:31 AM, Donald Stufft wrote:

On Nov 26, 2014, at 10:34 AM, Thomas Goirand
wrote:

Hi,

I tried to package suds-jurko. I was first happy to see
that there was some progress to make things work with
Python 3. Unfortunately, the reality is that suds-jurko has
many issues with Python 3. For example, it has many:

except Exception, e:

as well as many:

raise Exception, 'Duplicate key %s found' % k

This is clearly not Python3 code. I tried quickly to fix
some of these issues, but as I fixed a few, others appear.

So I wonder, what is the point of using suds-jurko, which
is half-baked, and which will conflict with the suds
package?

It looks like it uses 2to3 to become Python 3 compatible.

Outch! That's horrible.

I think it'd be best if someone spent some time on writing
real code rather than using such a hack as 2to3. Thoughts
anyone?

That sounds very subjective. If upstream is able to support
multiple python versions from the same codebase, then I see no
reason for them to split the code into multiple branches and
introduce additional burden syncing fixes between those.

/Ihar

Objectively, using 2to3 sux, and it's much better to fix the code,
rather than using such a band-aid. It is possible to support
multiple version of Python with a single code base. So many
projects are able to do it, I don't see why suds would be any
different.

Their support matrix starts from Python 2.4. Maybe that's a reason for
band-aid and not using runtime cross-version wrappers.
/Ihar

If that's the reason, then that's unreasonable. I may as well ask for
supporting my old Atari 16 bits computers too then...

So finally: I don't think using suds-jurko is of any help, unless it
does a big step to stay current with modern Python 3.

Thomas

responded Nov 28, 2014 by Thomas_Goirand (18,640 points)   3 11 16
...