settingsLogin | Registersettings

[openstack-dev] [cinder] A friendly reminder about reviews

0 votes

Hi all,

I would like to kindly ask you to pay a bit more attention to the following
areas:

  • Specs: we don' reviews specs as well as code:(. TBH, my specs reviews
    count is very low too.
  • os-brick and python-brick-cinderclient-ext - we've got a lack of code
    and review contribution for python-brick-cinderclient-ext
  • stable branches - let's help our stable maintainers team to review
    such patches; It's pretty sad for me and all contributors that we can't
    merge patches until branch EoL just because we didn't review them in time

Some useful links:

Regards,
Ivan Kolodyazhny,
http://blog.e0ne.info/


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
asked May 11, 2016 in openstack-dev by Ivan_Kolodyazhny (3,680 points)   5 7
retagged Jan 25, 2017 by admin

4 Responses

0 votes

On 05/11/2016 05:16 AM, Ivan Kolodyazhny wrote:
Hi all,

I would like to kindly ask you to pay a bit more attention to the following areas:

  • Specs: we don' reviews specs as well as code:(. TBH, my specs reviews count
    is very low too.
  • os-brick and python-brick-cinderclient-ext - we've got a lack of code and
    review contribution for python-brick-cinderclient-ext
  • stable branches - let's help our stable maintainers team to review such
    patches; It's pretty sad for me and all contributors that we can't merge
    patches until branch EoL just because we didn't review them in time

Just as a useful tip, I've saved the following as a "Cinder stable" item
on my gerrit menu (in gerrit prefs):

/q/status:open+AND+(project:openstack/cinder+OR+project:openstack/os-brick)+AND+NOT+branch:master


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded May 11, 2016 by Eric_Harney (2,100 points)   1 2
0 votes

Thanks, Eric.

I'm doing stable reviews on weekly basis, new gerrit dashboard will be very
helpful for me.

Regards,
Ivan Kolodyazhny,
http://blog.e0ne.info/

On Wed, May 11, 2016 at 5:05 PM, Eric Harney eharney@redhat.com wrote:

On 05/11/2016 05:16 AM, Ivan Kolodyazhny wrote:

Hi all,

I would like to kindly ask you to pay a bit more attention to the
following areas:

  • Specs: we don' reviews specs as well as code:(. TBH, my specs
    reviews count
    is very low too.
  • os-brick and python-brick-cinderclient-ext - we've got a lack of
    code and
    review contribution for python-brick-cinderclient-ext
  • stable branches - let's help our stable maintainers team to review
    such
    patches; It's pretty sad for me and all contributors that we can't
    merge
    patches until branch EoL just because we didn't review them in time

Just as a useful tip, I've saved the following as a "Cinder stable" item
on my gerrit menu (in gerrit prefs):

/q/status:open+AND+(project:openstack/cinder+OR+project:openstack/os-brick)+AND+NOT+branch:master


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded May 11, 2016 by Ivan_Kolodyazhny (3,680 points)   5 7
0 votes

And for completeness, I'd also like to mention that there is this nice
dashboard:

http://status.openstack.org/reviews/#cinder


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded May 11, 2016 by Eric_Harney (2,100 points)   1 2
0 votes

Cinder is definitely lacking reviewing force. I remember 2 years ago
comparing with today and I can tell that patches are taking a lot longer to
get reviewed.

This link is also very useful to triage incoming patches:

https://review.openstack.org/#/dashboard/?foreach=project:^openstack/.*cinder.*
status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1 NOT
label:Code-Review<=-1,self NOT label:Code-Review>=1,self&title=Cinder
Review Inbox&Cinder Specs=project:openstack/manila-specs&Bug
Fixes=topic:^bug/.*&Needs Feedback (Changes older than 5 days that have not
been reviewed by anyone)=NOT label:Code-Review<=2 age:5d&You are a
reviewer, but haven't voted in the current revision=reviewer:self&Needs
final +2=label:Code-Review>=2 limit:50&New
Contributors=reviewer:10068&Passed Jenkins, No Negative Feedback=NOT
label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50&Wayward Changes
(Changes with no code review in the last 2days)=NOT label:Code-Review<=2
age:2d

Huge link but the result is beautiful :)

Erlon

On Wed, May 11, 2016 at 11:19 AM, Eric Harney eharney@redhat.com wrote:

And for completeness, I'd also like to mention that there is this nice
dashboard:

http://status.openstack.org/reviews/#cinder


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
responded May 24, 2016 by Erlon_Cruz (3,020 points)   2 2
...